[vlc-devel] commit: input: Remove p_playlist gc signaling now that the playlist is aware of vlc_InputSelectedStreamChanged . (Pierre d'Herbemont )

[Pierre d'Herbemont]

Now there is no more the circular dependency between playlist<->input<- 
 >vout in libvlccore.

However some access or demux modules are still illegaly using the  
playlist directly. This is wrong as this creates a circular dependency  
between playlist and input indirectly.

Pierre.

On Jun 14, 2008, at 4:42 PM, git version control wrote:

> vlc | branch: master | Pierre d'Herbemont <pdherbemont at videolan.org>  
> | Sat Jun 14 16:25:59 2008 +0200|  
> [e018b9f1b325d9b10dd877428740bccc50eb71e5]
>
> input: Remove p_playlist gc signaling now that the playlist is aware  
> of vlc_InputSelectedStreamChanged.
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e018b9f1b325d9b10dd877428740bccc50eb71e5
> ---
>
> src/input/es_out.c |   11 -----------
> 1 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/src/input/es_out.c b/src/input/es_out.c
> index df4fb09..f25f545 100644
> --- a/src/input/es_out.c
> +++ b/src/input/es_out.c
> @@ -40,7 +40,6 @@
>
> #include "input_internal.h"
>
> -#include "vlc_playlist.h"
> #include <vlc_iso_lang.h>
> /* FIXME we should find a better way than including that */
> #include "../text/iso-639_def.h"
> @@ -1689,16 +1688,6 @@ static int EsOutControl( es_out_t *out, int  
> i_query, va_list args )
>                }
>            }
>            {
> -                /* FIXME: we don't want to depend on the playlist */
> -                playlist_t * p_playlist = pl_Yield( p_sys->p_input );
> -                if( VLC_OBJECT(p_playlist) == p_sys->p_input )
> -                {
> -                    PL_LOCK;
> -                    p_playlist->gc_date = mdate();
> -                    vlc_object_signal_unlocked( p_playlist );
> -                    PL_UNLOCK;
> -                }
> -                pl_Release( p_sys->p_input );
>                vlc_event_t event;
>                event.type = vlc_InputSelectedStreamChanged;
>                vlc_event_send( &p_sys->p_input->p->event_manager,  
> &event );
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel