[vlc-devel] commit: Work-around a playlist-core bug which prevents 'intf-change' to be set on-time after the addition of new inputs. ( Felix Paul Kühne )

[git version control]

vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Sat Jun 14 21:23:54 2008 +0200| [3646783cd4862a71c0ae29ee114918cdc98fafeb]

Work-around a playlist-core bug which prevents 'intf-change' to be set on-time after the addition of new inputs.

However, this doubles the idle-CPU load, so we may to fix that in core properly..

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3646783cd4862a71c0ae29ee114918cdc98fafeb
---

 modules/gui/macosx/intf.m     |    3 ++-
 modules/gui/macosx/playlist.m |    4 +---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/modules/gui/macosx/intf.m b/modules/gui/macosx/intf.m
index 4069296..e22aa06 100644
--- a/modules/gui/macosx/intf.m
+++ b/modules/gui/macosx/intf.m
@@ -272,8 +272,8 @@ static int PlaylistChanged( vlc_object_t *p_this, const char *psz_variable,
                      vlc_value_t old_val, vlc_value_t new_val, void *param )
 {
     intf_thread_t * p_intf = VLCIntf;
-    p_intf->p_sys->b_playlist_update = true;
     p_intf->p_sys->b_intf_update = true;
+    p_intf->p_sys->b_playlist_update = true;
     p_intf->p_sys->b_playmode_update = true;
     p_intf->p_sys->b_current_title_update = true;
     return VLC_SUCCESS;
@@ -1452,6 +1452,7 @@ static VLCMain *_o_sharedMainInstance = nil;
     {
         p_intf->p_sys->i_play_status = END_S;
         p_intf->p_sys->b_intf_update = true;
+        p_intf->p_sys->b_playlist_update = true;
         [self playStatusUpdated: p_intf->p_sys->i_play_status];
         [o_embedded_window playStatusUpdated: p_intf->p_sys->i_play_status];
         [self setSubmenusEnabled: FALSE];
diff --git a/modules/gui/macosx/playlist.m b/modules/gui/macosx/playlist.m
index b9927dd..866e852 100644
--- a/modules/gui/macosx/playlist.m
+++ b/modules/gui/macosx/playlist.m
@@ -456,10 +456,8 @@
 
 - (void)playlistUpdated
 {
-    unsigned int i;
-
     /* Clear indications of any existing column sorting */
-    for( i = 0 ; i < [[o_outline_view tableColumns] count] ; i++ )
+    for( unsigned int i = 0 ; i < [[o_outline_view tableColumns] count] ; i++ )
     {
         [o_outline_view setIndicatorImage:nil inTableColumn:
                             [[o_outline_view tableColumns] objectAtIndex:i]];