[vlc-devel] [PATCH] Correctly respond to a Connection Close message.

Rémi Denis-Courmont rdenis at simphalempin.com
Sun Jun 15 10:09:55 CEST 2008


Le dimanche 15 juin 2008 08:23:05 Bill C. Riemers, vous avez écrit :
> It is just that I started with what I thought was a request for a minor
> bug fix.   I didn't like having an error message pop-up telling me all
> my AVI's are corrupt when they aren't, and I like to be able to seek to
> the previous place I was watching my video if I need to stop it for some
> reason.

> I started off with a simply patch of just a few lines.  Now after
> responding to fix each objection I have done six revisions of that
> patch, and I'm still not any closer to having a bug fix included in the
> next release.

This is not a bug fix. The bug is in the AVI demux. Lets call a cat a cat, 
this is a regression in the AVI demux - it had been working for several years 
without seeking, and it broke sometime during the 0.9.0 development.

You are improving the HTTP access. This is probably a good idea, but it will 
probably never fix the AVI problem. We have other access plugins, such as 
FTP, that will continue to exhibit the problem.

Of course, we can change the AVI demux to use CAN_SEEK instead of 
CAN_FASTSEEK. If nobody fixes the AVI demux soon enough, we may end up doing 
this *work-around* for 0.9.0.

But it should be understandable that I would rather not have the _same_ patch 
doing both a work-around to the AVI demux, and some loosely-related 
improvements to the HTTP access, right? If you don't feel like doing it 
yourself because you don't like/know git, that's fine, if you do tell.

By the way, b_persist should probably default to false on HTTP/1.0, no?

Rémi Denis-Courmont

More information about the vlc-devel mailing list