[vlc-devel] [PATCH] support libproxy for http access

Dominique Leuenberger dominique at leuenberger.net
Sun Jun 15 10:55:22 CEST 2008


On Sun, 15 Jun 2008 10:19:07 +0300
Rémi Denis-Courmont <rdenis at simphalempin.com> wrote:

> Le lundi 9 juin 2008 20:38:33 Dominique Leuenberger, vous avez écrit :
> > On Mon, 2008-06-09 at 20:30 +0300, Rémi Denis-Courmont wrote:
> > > Le dimanche 8 juin 2008 17:10:20 Dominique Leuenberger, vous avez
> > > écrit :
> > > > On Sun, 2008-06-08 at 11:54 +0300, Rémi Denis-Courmont wrote:
> > > > > * Please squash fixes with the origin (buggy) patches (git
> > > > > rebase -i ...).
> > > >
> > > > Another updated patch to support libproxy in http. I think I
> > > > incorporated all the comments I received so far.
> > > >
> > > > Please forgive the endless added round trips it takes;
> > >
> > > +       free(pf);
> > >
> > > Hmm, looks odd, but I don't know the libproxy API.
> >
> > You're right...
> > this should be
> > px_proxy_factory_free(pf);
> >
> > Shall I resubmit the patch?
> 
> Yes.
> 

The patch was resubmitted on June 10th, including better logic for
configure script to detect automatically and support --enable and
--disable - libproxy.

Please review.

Dominique



More information about the vlc-devel mailing list