[vlc-devel] [PATCH] Add support for libproxy to the access module http. Libproxy reads proxy settings from kde, gnome, networkmanager, environment

Dominique Leuenberger dominique at leuenberger.net
Sun Jun 15 13:03:16 CEST 2008


On Sun, 15 Jun 2008 13:46:41 +0300
Rémi Denis-Courmont <rdenis at simphalempin.com> wrote:

> Le dimanche 15 juin 2008 12:25:36 Dominique Leuenberger, vous avez
> écrit :
> > Also fixed the free(pf).. I though I already squashed that one.
> 
> The memory error handling code makes no sense. And you cannot use
> pointers arithmetic for string comparison.
> 
For the memory error handling here an updated patch.

For the other part, I'm not sure what you mean :(
Is it regarding
  if(proxies[0] != "direct://")

? How else can I write this?

Dominique

(The patch attached here shows what I mean with replacement of the
memory error handling)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-support-for-libproxy-to-the-access-module-http.patch
Type: text/x-patch
Size: 2976 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080615/4d9ab6bb/attachment.bin>


More information about the vlc-devel mailing list