[vlc-devel] [PATCH] Add support for libproxy to the access module http. Libproxy reads proxy settings from kde, gnome, networkmanager, environment

Pierre d'Herbemont pdherbemont at free.fr
Sun Jun 15 14:07:10 CEST 2008


On Jun 15, 2008, at 1:49 PM, Dominique Leuenberger wrote:

> On Sun, 15 Jun 2008 13:01:01 +0200
> Pierre d'Herbemont <pdherbemont at free.fr> wrote:
>
>>
>> On Jun 15, 2008, at 11:25 AM, Dominique Leuenberger wrote:
>>
>>> +#ifdef HAVE_PROXY_H
>>> +    else
>>> +    {
>>> +	pxProxyFactory *pf = px_proxy_factory_new();
>>>
>> We tend not to use tab, but 4 spaces for indentation... Could you
>> fix that too?
>>
>
> Oh sorry for that... put spaces all over now.

Well, there are still tabs in latest version of your patch.

Rest seems better :)

Pierre.



More information about the vlc-devel mailing list