[vlc-devel] [PATCH] MMS stream pausing

[bl4]

Rémi Denis-Courmont wrote:
> Le dimanche 15 juin 2008 18:45:39 bl4, vous avez écrit :
>   
>> Should be fixed now. I've split the patch into 2 parts in case there are
>> other problems with the thread.
>>     
>
> Unfortuantely, net_Write() (in mms_CommandSend()) is not thread-safe if the 
> socket handle is the same. You could end up mixing up bytes from different 
> commands on the wire :(
>   

I've set a lock inside mms_CommandSend().

> Also, you should probably use vlc_object_timedwait() rather than msleep(), so 
> that we don't need to wait 10 seconds to stop the stream.
>   

Thanks for pointing it out. I didn't notice it.

> And please use your real name when sending patches.
>   

-- 
bl4

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-MMS-stream-pausing-keep-the-connection-alive.patch
Type: text/x-patch
Size: 5655 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080615/455c04ee/attachment.bin>