[vlc-devel] [PATCH] MMS stream pausing

bl4 bl4 at playker.info
Mon Jun 16 17:42:39 CEST 2008


Rémi Denis-Courmont wrote:
> Le dimanche 15 juin 2008 23:49:06 bl4, vous avez écrit :
>   
>> Rémi Denis-Courmont wrote:
>>     
>>> Le dimanche 15 juin 2008 18:45:39 bl4, vous avez écrit :
>>>       
>>>> Should be fixed now. I've split the patch into 2 parts in case there are
>>>> other problems with the thread.
>>>>         
>>> Unfortuantely, net_Write() (in mms_CommandSend()) is not thread-safe if
>>> the socket handle is the same. You could end up mixing up bytes from
>>> different commands on the wire :(
>>>       
>> I've set a lock inside mms_CommandSend().
>>     
>
> Sorry, I cannot seem to apply the patch, not even on top of your own last 
> commit within master.
>   

It's because I've split the patch into 2 files: 
0001-MMS-stream-pausing.patch and 
0001-MMS-stream-pausing-keep-the-connection-alive.patch. The second goes 
on top of the first and in my last mail I only updated the second. (I 
did it because it's possible to pause without keeping the connection 
alive and I didn't know if the last patch was good enough to be applied).

-- 
bl4




More information about the vlc-devel mailing list