[vlc-devel] [PATCH] Add Scaletempo audio filter

Rov Juvano rovjuvano at users.sourceforge.net
Tue Jun 17 01:48:39 CEST 2008


On Mon, Jun 16, 2008 at 09:40:35PM +0300, Rémi Denis-Courmont wrote:
> Le lundi 16 juin 2008 08:37:21 Rov Juvano, vous avez écrit :
> > Scaletempo maintains the audio pitch when playback rate != 1.0 (i.e.
> > no chipmunk effect).  This fixes the pitch scaling caused by using the
> > resampler to handle playback rate.
>
> While the feature sounds (ahaha) cool, I am not very keen on changing the
> audio output code (and breaking the ABI for that) during the feature
> freeze :/

So, you're telling me you'd rather stick it into to git for
who knows how long because you're in an earlier timezone?
Darn my insistence on one last test.  That last rebase turned
into hours of debugging and bisecting the upstream commits
that broke my test apps.

Anyway, I announced over a week ago I was adding this.  Was
that not enough?  Even so, this feature was started over a
year ago by Laurent Aimar.  Are you saying you'd rather leave
it half done for 0.9.0?

>
> > Ported from GStreamer.  Inspired by SoundTouch library by Olli Parviainen.
>               ^^^^^^^^^
> Which means it should be GPL compatible, but what about the copyright
> statements?

I can license it however I want.  Was GPL 2 or later, not acceptable?

--
rovjuvano




More information about the vlc-devel mailing list