[vlc-devel] [PATCH] Bug fix: Connection: close is a server side message

[Ilkka Ollakka]

On ma 16. kesäkuuta 2008 18:09:32, Bill C. Riemers wrote:
> 

I have to disagree with this one, rfc 2616 section 8.1.2.1 says

...In case the client does not want to maintain a connection for more
than that request, it SHOULD send a Connection header including the
connection-token close...


> From 063dfca2e7023dc3fc83bc193aaef0bf8eac877a Mon Sep 17 00:00:00 2001
> From: Bill C Riemers <docbill at hartnell.local>
> Date: Mon, 16 Jun 2008 11:58:50 -0400
> Subject: [PATCH] Bug fix: "Connection: close" is a server side message, not a client message.
> 
> ---
>  modules/access/http.c |   12 ++----------
>  1 files changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/modules/access/http.c b/modules/access/http.c
> index a5cfefd..f40ee96 100644
> --- a/modules/access/http.c
> +++ b/modules/access/http.c
> @@ -1196,16 +1196,8 @@ static int Request( access_t *p_access, int64_t i_tell )
>      net_Printf( VLC_OBJECT(p_access), p_sys->fd, pvs, "Icy-MetaData: 1\r\n" );
>  
>  
> -    if( p_sys->b_continuous )
> -    {
> -        net_Printf( VLC_OBJECT( p_access ), p_sys->fd, pvs,
> -                    "Connection: Keep-Alive\r\n" );
> -    }
> -    else if( p_sys->i_version == 1 )
> -    {
> -        net_Printf( VLC_OBJECT( p_access ), p_sys->fd, pvs,
> -                    "Connection: Close\r\n");
> -    }
> +    net_Printf( VLC_OBJECT( p_access ), p_sys->fd, pvs,
> +                "Connection: Keep-Alive\r\n" );
>  
>      if( net_Printf( VLC_OBJECT(p_access), p_sys->fd, pvs, "\r\n" ) < 0 )
>      {
> -- 
> 1.5.5.1
> 

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel


-- 
Ilkka Ollakka
Mustgo, n.:
	Any item of food that has been sitting in the refrigerator so
long it has become a science project.
		-- Sniglets, "Rich Hall & Friends"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080617/6e9d6577/attachment.sig>