[vlc-devel] [PATCH] Bug fix: Connection: close is a server side message

[Ilkka Ollakka]

On ti 17. kesäkuuta 2008 02:08:03, Bill C. Riemers wrote:
> 
> True.  But the fact we can call Request multiple times, means we do want
> the connection persistent.   This is also evidence
> by the fact the code explicitly sent "Keep-Alive" for 1.0 servers.
 
 Youre right on that one

> If we want to Keep-Alive the connection for 1.1 servers, then we better
> not be sending a Connection: close.
 


> >> -    else if( p_sys->i_version == 1 )
> >> -    {
> >> -        net_Printf( VLC_OBJECT( p_access ), p_sys->fd, pvs,
> >> -                    "Connection: Close\r\n");
> >> -    }
> >> +    net_Printf( VLC_OBJECT( p_access ), p_sys->fd, pvs,
> >> +                "Connection: Keep-Alive\r\n" );

Wouldn't it then be better to change that Connection: Close to
Keep-Alive inside http/1.1 check there instead sending it also to 1.0
servers (thou it ain't wrong to send it to them too, but just caught my
eye on that comment on connection being only server-side message).

-- 
Ilkka Ollakka
"Matrimony isn't a word, it's a sentence."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080617/f6620c77/attachment.sig>