[vlc-devel] [RFC][PATCH] fix mozplug toolbar

[KH KH]

2008/6/17 Bill C. Riemers <briemers at redhat.com>:
> Sorry to be a bother.  But if you are patching it, you must be able to
> get it to compile.   Can you give me a clue where to find mozilla-config
> so I can get it to compile as well?

You can take a look on the WIP patch i have for 0.8.6h in livna.
the problem is that we need to get rid of mozilla-config.h
That can be done by ACdefining the needed value from configure.ac
As this is a highly inter- OSes patch, i can only provide a not
mergeable but functional patch that will works on linux with
vlc-0.8.6h...
and xulrunner-1.9(stable)

Nicolas (kwizart)



> Bill
>
>
> Anthony Loiseau wrote:
>> Hi all,
>>
>> As discussed on the IRC,
>> Mozilla-plugin ODS-toolbar (X11) seems to not work.
>>
>> A while ago, I have managed to patch it but had not found the time to
>> make my patches clean, so did't propose it (part of patch 0002)
>> As asked, here there are (I've done a pull rebase before).
>>
>>
>> I have no time to test it, sorry. The reason why I add RFC as subject.
>> I find them not clean because:
>>
>>  - one patch fix 2 things (need a rebase -i to be cleaner)
>>  - timeline didn't worked, iirc (but play/pause worked)
>>
>>
>> I don't remember if last patch (play/pause) was very usefull, you should
>> test with and without. It was about pausing after the end of the video
>> and pausing several times.
>> The flag is_playing did not come back to "play" when quitting pause
>> calling libvlc_play, so I had thought to quit it with another
>> libvlc_pause (this is a toggle function).
>>
>>
>> Hope I am clear enough,
>> good luck with those patches and sorry for the lack of time to send them
>> just clean.
>> _anthony (thannoy)
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> http://mailman.videolan.org/listinfo/vlc-devel
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vlc-0.8.6e-xulrunner.patch
Type: text/x-patch
Size: 5384 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080618/85e297d9/attachment.bin>