[vlc-devel] commit: Typo in pl_Release(); (Jean-Paul Saman )

[Jean-Paul Saman]

Remi Denis-Courmont wrote:
> This commit looks like it's adding a bug where there was none.

I don't thinks so, since p_this is not the playlist. First the playlist 
is yielded and then p_this was given to pl_Release().

If this is not the intended  way this function works, then its prototype 
is broken. It just doesn't make sense to me to yield the playlist and 
then release another object.

If this is wrong then all instances of pl_Release() should be checked 
because most release the playlist object iso the object it is yielded from.

> 
> Remi Denis
> 
> -- message original --
> Sujet:	[vlc-devel] commit: Typo in pl_Release(); (Jean-Paul Saman )
> De:	git at videolan.org (git version control)
> Date:		18.06.2008 10:06
> 
> vlc | branch: master | Jean-Paul Saman <jpsaman at videolan.org> | Sun Jun 15 18:45:16 2008 +0200| [9bddd7d37362150b20961c45c0e508356251e4f9]
> 
> Typo in pl_Release();
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9bddd7d37362150b20961c45c0e508356251e4f9
> ---
> 
>  src/video_output/vout_intf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/video_output/vout_intf.c b/src/video_output/vout_intf.c
> index 2457bbd..ab02bd8 100644
> --- a/src/video_output/vout_intf.c
> +++ b/src/video_output/vout_intf.c
> @@ -1199,7 +1199,7 @@ static int OnTopCallback( vlc_object_t *p_this, char const *psz_cmd,
>      var_Create( p_playlist, "video-on-top", VLC_VAR_BOOL );
>      var_Set( p_playlist, "video-on-top", newval );
>  
> -    pl_Release( p_this );
> +    pl_Release( p_playlist );
>      return VLC_SUCCESS;
>  }
>  
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>