[vlc-devel] commit: Add callback to spu-es from the input. (Jean-Paul Saman )

[Felix Paul Kühne]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On 19.06.2008, at 11:48, Remi Denis-Courmont wrote:

> Changing a value from another thread without barrier nor atomicity...
>
> On OSX, you may afford to do that, because you have a well-known very
> finite set of CPU architectures, such that you can assume that  
> setting a
> bool or an integer might just work.
>
> On portable code, such as the Qt4 interface, it is simply wrong. In  
> fact,
> it probably fails on real multiprocessors. Yes, there are many such  
> errors
> in VLC. One easy way to find some is to grep for msleep (to the best  
> of my
> knowledge msleep is not a memory barrier).
>

Alright, I agree to your points. However, please let people test this  
code in the real world, meaning on *BSD, Linux and Win32 (plus  
possibly OS X). If it works for them, let them use this code for 0.9.0  
and lets fix it after 0.9.0. If it doesn't work as you predicted, it  
needs to be fixed immediately of course.

Fine for j-b and you release management-wise?

Best,
Felix


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)

iEYEARECAAYFAkhaLogACgkQtUgezvXAcGM5VQCfa1pJkZwTRqOiGQUoWWPvGg0m
DKAAnR2Z1+NEueJ5kQnZ4VaLacwrWM0I
=7z1F
-----END PGP SIGNATURE-----