[vlc-devel] commit: Add callback to spu-esfrom?theinput.?(Jean-Paul Saman )

Ilkka Ollakka ilkka.ollakka+vlc at oamk.fi
Thu Jun 19 23:25:42 CEST 2008

On to 19. kesäkuuta 2008 14:14:31, Remi Denis-Courmont wrote:
> If it's a pure set/get pattern, you can use vlc_spin_lock/vlc_spin_unlock
> around all set/get operations. However, I wonder why use a callback at all
> then - you could read the VLC variable from the input-or-whatever object
> directly, no? (VLC variables are always thread-safe)
 I looked around inputmanager, and didn't find any other use for
 callbacks that set those b_has_ stuff, so it's simpler just to change
 audio/video to directly check vlc variable. Thanks for the tip.

 Thou that changeSPU stuff did some more, and I changed it to send event
 for customhandler (mostly because it don't need to be in callback that
 long then). 

 I think I didn't miss any obvius points in this one, but please review.

Ilkka Ollakka
There is a green, multi-legged creature crawling on your shoulder.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-remote-audio-video-change-callbacks-with-current-fo.patch
Type: text/x-patch
Size: 8048 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080620/f9442f55/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080620/f9442f55/attachment.sig>

More information about the vlc-devel mailing list