[vlc-devel] [PATCH] Add Scaletempo audio filter

[Laurent Aimar]

On Fri, Jun 20, 2008, Rov Juvano wrote:
> > > I thought they wouldn't be called if the values were out
> > > bounds.  Are the min/max of add_*_with_range just informative?
> >  I have no idea if they work when set by var_Set*. So I will wait for someone
> > to correct me.
> 
> You were right.
> 
> I'm going to remove them since they aren't really interactive
> parameters.
Ok.

> You're going to have convince me to do it differently than
> the other audio filters, or is this because I left out the
> check for the output format:
 Sorry, I did not remember correctly the (brain-dead) audio filter API.

> if( p_filter->input.i_format != VLC_FOURCC('f','l','3','2') )
> should be
> if( p_filter->input.i_format != VLC_FOURCC('f','l','3','2' ) ||
>     p_filter->output.i_format != VLC_FOURCC('f','l','3','2') )
 Good catch.

> This also depends on what you mean by high speed, which by
> my definition, vlc's faster/slower falls into that category.
> I'm targetting upto +-25% where speech is still fairly easy
> to understand.  I haven't been too concerned with speeds
> beyond +-100%.
 Well, beyond 2x it is really hard to follow/understand anything.
That was my upper limit (but can be usefull when searching a scene).

-- 
fenrir