[vlc-devel] commit: Remove BlockingQueuedConnection, hopefully not needed ( Rémi Denis-Courmont )

git version control git at videolan.org
Sun Jun 22 16:27:30 CEST 2008


vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> | Sun Jun 22 17:29:30 2008 +0300| [e2499dc3873f07fc916f292187c07d0eff74061c]

Remove BlockingQueuedConnection, hopefully not needed

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e2499dc3873f07fc916f292187c07d0eff74061c
---

 modules/gui/qt4/components/interface_widgets.cpp |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/modules/gui/qt4/components/interface_widgets.cpp b/modules/gui/qt4/components/interface_widgets.cpp
index 1256f4b..43b88e1 100644
--- a/modules/gui/qt4/components/interface_widgets.cpp
+++ b/modules/gui/qt4/components/interface_widgets.cpp
@@ -73,13 +73,8 @@ VideoWidget::VideoWidget( intf_thread_t *_p_i ) : QFrame( NULL ), p_intf( _p_i )
     setPalette( plt );
     setAttribute( Qt::WA_PaintOnScreen, true );
 
-    /* The core can ask through a callback to show the video.
-     * NOTE: We need to block the video output core until the window handle
-     * is ready for use (otherwise an X11 invalid handle failure may occur).
-     * As a side effect, it is illegal to emit askVideoWidgetToShow from
-     * the same thread as the Qt4 thread that owns this. */
-    QObject::connect( this, SIGNAL(askVideoWidgetToShow()), this, SLOT(show()),
-                      Qt::BlockingQueuedConnection );
+    /* The core can ask through a callback to show the video. */
+    CONNECT( this, askVideoWidgetToShow(), this, show() );
 
     /* The core can ask through a callback to resize the video */
    // CONNECT( this, askResize( int, int ), this, SetSizing( int, int ) );




More information about the vlc-devel mailing list