[vlc-devel] Array indexing bug in modules/mux/mpeg/csa.c

[Kaloyan Kovachev]

On Mon, 23 Jun 2008 16:04:08 +0200, Remi Denis-Courmont wrote
> On Mon, 23 Jun 2008 14:35:30 +0100, "ogg.k.ogg.k at googlemail.com"
> <ogg.k.ogg.k at googlemail.com> wrote:
> > I just noticed a compiler warning about this in 0.8.6g:
> > 
> > Line 288, the filling of kb indexes the second subscript with too
> > large a value. It just happens that the overflow also falls within
> > the array so it doesn't overwrite something else, but a bug anyway.
> > 
> > No patch, as I have no clue what this does, just looked after seeing
> > the warning fly past.
> 
> I am pretty sure there was a patch for this in the master branch. I thought
> it had been backported to 0.8.6h, but maybe not.
> 
the change is quite simple actualy (single line):

@@ -278,7 +335,7 @@
     int i,j,k;
     int bit[64];
     int newbit[64];
-    int kb[9][8];
+    int kb[8][9];

> -- 
> [UTF-8?]RГ©mi
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel