[vlc-devel] commit: Remove unneeded msg_Err and check malloc return value. ( Rémi Duraffort )

git version control git at videolan.org
Mon Jun 23 22:05:43 CEST 2008


vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Mon Jun 23 21:57:54 2008 +0200| [71142c5c0b2a3faab6f07b4a801893c07c38b56e]

Remove unneeded msg_Err and check malloc return value.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=71142c5c0b2a3faab6f07b4a801893c07c38b56e
---

 modules/access_output/udp.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/modules/access_output/udp.c b/modules/access_output/udp.c
index 20520fc..527e5be 100644
--- a/modules/access_output/udp.c
+++ b/modules/access_output/udp.c
@@ -174,14 +174,16 @@ static int Open( vlc_object_t *p_this )
     }
 
     if( !( p_sys = calloc ( 1, sizeof( sout_access_out_sys_t ) ) ) )
-    {
-        msg_Err( p_access, "not enough memory" );
         return VLC_ENOMEM;
-    }
     p_access->p_sys = p_sys;
 
     i_dst_port = DEFAULT_PORT;
     char *psz_parser = psz_dst_addr = strdup( p_access->psz_path );
+    if( !psz_dst_addr )
+    {
+        free( p_sys );
+        return VLC_ENOMEM;
+    }
 
     if (psz_parser[0] == '[')
         psz_parser = strchr (psz_parser, ']');
@@ -197,7 +199,6 @@ static int Open( vlc_object_t *p_this )
         vlc_object_create( p_access, sizeof( sout_access_thread_t ) );
     if( !p_sys->p_thread )
     {
-        msg_Err( p_access, "out of memory" );
         free (p_sys);
         free (psz_dst_addr);
         return VLC_ENOMEM;




More information about the vlc-devel mailing list