[vlc-devel] commit: Fix the update system, based on funman patch + some modifications. ( Rémi Duraffort )

Rémi Denis-Courmont rdenis at simphalempin.com
Wed Jun 25 23:01:47 CEST 2008


Le mercredi 25 juin 2008 23:42:57 git version control, vous avez écrit :
> +    vlc_mutex_unlock( &p_update->lock );
>      vlc_mutex_destroy( &p_update->lock );

Having these two lines one after the other is almost always a bug.

If someone else is waiting on the mutex, then it will crash.
If nobody is waiting on the mutex, there is no need to lock it.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list