[vlc-devel] [PATCH] [codec/dirac.c] Fix aspect ratio signalling and presentation time stamps
davidf+nntp at woaf.net
Sun Jun 29 18:09:19 CEST 2008
On 2008-06-29, Laurent Aimar <fenrir at via.ecp.fr> wrote:
> On Sun, Jun 29, 2008, David Flynn wrote:
>> - Do not set p_pic->date = p_block->i_pts, p_block will be several frames
>> ahead of p_pic, worse it isn't in presentation order. Since there is
>> no method of tagging input blocks with PTS through the decoder, fake
>> the PTS at output based upon the an initial PTS and frame rate.
> This is not a usable solution:
> - if you are not using an input file, you do not control the pace. The
> difference between the real PTS and the fake one will grow indefinitly.
This is merely a get-you-home solution/hack. As it currently stands,
without this 'fix', it isn't possible to use codec/dirac.c to decode
anything. It will fail in precicely the way you say. The solution is
to add tagging in the same way i've done in schroedinger.c.
I'll have a look at this in a bit.
> Unless the support by ffmpeg is really worst, I would prefer letting ffmpeg
> decode dirac until this issue is fixed.
I've not managed to see pictures when using avcodec and avcodec's
That said, codec/schroedinger.c would be my prefered method.
More information about the vlc-devel