[vlc-devel] [PATCH 1/3] ts demux: add support for dirac streams via registration_descriptor

[Laurent Aimar]

On Sun, Jun 29, 2008, David Flynn wrote:
> So, we like VC-1, AC-3 (iirc), etc., pick a random number from the User
> defined section of stream_type.
 Ok, I was just curious.

> Infact given that we [will] (as have VC-1/AC-3) have a well defined
 VC-1 uses 0xEA but AC-3 can use 0x06 ;)

> registration_descriptor, one has to wonder why any attention is given to
> the stream_type -- as long as it didn't conflict, ie, keep to
> UserDefined, (or for some private PES (0x6)).
> 
> This does also raise a question over demux/ts.c -- there is a huge
> section that does (effectively):
> switch (stream_type):
> ...
> case n:
>  /* load of code to check for registation descriptor */
>  /* load of code to validate format_identifier */
>  /* specific bits */
> case m:
>  /* load of code to check for registation descriptor */
>  /* load of code to validate format_identifier */
>  /* specific bits */
> case ...
> case x:
>  /* load of code to check for registation descriptor */
>  /* load of code to validate format_identifier */
>  /* specific bits */
> 
> That could probably be made somewhat simpler?
 Probably, using both stream_type and registration descriptor made
it more robust to stream corruption (but I am pretty sure that the curent
state is due to the way detections were added, one after one).

-- 
fenrir