[vlc-devel] commit: We want to check QT4 version at runtime rather than buildtime ( Rafaël Carré )

git version control git at videolan.org
Sat Mar 8 14:08:03 CET 2008


vlc | branch: master | Rafaël Carré <funman at videolan.org> | Sat Mar  8 13:53:08 2008 +0100| [ee61e050560dec84278eed6a1dcb3120e6eddddc]

We want to check QT4 version at runtime rather than buildtime

Revert "thanks for Trolltech fixing their mess, after a bug request that using valgrind caused the same kind of problem."

This reverts commit d8fc5a1ddb75eb9d53fc090ad1e5e8bfe2522bb0.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ee61e050560dec84278eed6a1dcb3120e6eddddc
---

 modules/gui/qt4/qt4.cpp |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/gui/qt4/qt4.cpp b/modules/gui/qt4/qt4.cpp
index 26e1e04..fa2b279 100644
--- a/modules/gui/qt4/qt4.cpp
+++ b/modules/gui/qt4/qt4.cpp
@@ -287,8 +287,8 @@ static void Init( intf_thread_t *p_intf )
 
     Q_INIT_RESOURCE( vlc );
 
-#if !defined(WIN32) && !defined(__APPLE__) && QT_VERSION < 0x040400
-    /* KLUDGE for QT4 < 4.4.0 (which use libgconf to avoid that)
+#if !defined(WIN32) && !defined(__APPLE__)
+    /* KLUDGE:
      * disables icon theme use because that makes Cleanlooks style bug
      * because it asks gconf for some settings that timeout because of threads
      * see commits 21610 21622 21654 for reference */




More information about the vlc-devel mailing list