[vlc-devel] commit: Saveing Window Positions useing the QT defined methods as far as possible. ( André Weber )

[Andre Weber]

>>Uncommenting the dock is one of those.
its still inside #if  0  -- the comment was just double disabling the code -- so it still disabled
if you mean the constructor of  "Maininterface"?


>>Using the Playlist Dialog that should probably not being used in non-DP
>>mode is another...
I agree - but currently it is the way like it is done - so that we may have two instances
of the PlayListWidget - at the same time - storing there positions / arrangement to
the same location.
And also storing its size - which isn't quite necessary if this widget is used inside the dialog
- where the size in set / defined by the dialog. (may only give trouble)

Better would be having only one instance of PlayListWidget ... and move this component
to the dialog - if the user undocks it.  But I'am don't know how to do this with QT
without getting trouble on cleanup - and who will be responsible for cleanup in such
a case?

André Weber



----- Original Message ----- 
From: "Jean-Baptiste Kempf" <jb at videolan.org>
To: "Mailing list for VLC media player developers" <vlc-devel at videolan.org>
Sent: Sunday, March 09, 2008 9:05 PM
Subject: Re: [vlc-devel]commit: Saveing Window Positions useing the QT defined methods as far as possible. ( André
Weber )


On Sun, Mar 09, 2008, git version control wrote :
> vlc | branch: master | André Weber <atmo at videolan.org> | Sun Mar  9 21:02:46 2008 +0100|
[894f52c816798d639d69803a77b8e9120088bb3b]
>
> Saveing Window Positions useing the QT defined methods as far as possible.
> On first start if there is no position info stored - try center the dialogs
> on the primary desktop/screen. (or same screen as the controller)
>
> the component playlist shall not save there settings to a fixed location,
> so it may become problematic if we use the component twice - like it
> is done. The location shall be given controlled by its owner component
> or window.

This commit is wrong in many aspects...

Uncommenting the dock is one of those.
Using the Playlist Dialog that should probably not being used in non-DP
mode is another...
Moreover, being a component doesn't mean that it will be used more than
once...

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
http://mailman.videolan.org/listinfo/vlc-devel