[vlc-devel] commit: verify asprintf() return value, fix indentation ( Rafaël Carré )
git version control
git at videolan.org
Wed Mar 12 21:19:11 CET 2008
vlc | branch: master | Rafaël Carré <funman at videolan.org> | Wed Mar 12 16:23:26 2008 +0100| [e7003c92f06a1c667c3ce570d2c5eb6eecbc5dde]
verify asprintf() return value, fix indentation
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e7003c92f06a1c667c3ce570d2c5eb6eecbc5dde
---
modules/codec/faad.c | 32 +++++++++++++++++---------------
1 files changed, 17 insertions(+), 15 deletions(-)
diff --git a/modules/codec/faad.c b/modules/codec/faad.c
index b9c7dfd..054e1df 100644
--- a/modules/codec/faad.c
+++ b/modules/codec/faad.c
@@ -348,23 +348,25 @@ static aout_buffer_t *DecodeBlock( decoder_t *p_dec, block_t **pp_block )
if( (p_sys->b_sbr != frame.sbr || p_sys->b_ps != frame.ps) &&
p_dec->p_parent->i_object_type == VLC_OBJECT_INPUT )
{
- input_thread_t *p_input = (input_thread_t *)p_dec->p_parent;
- char *psz_cat;
- const char *psz_ext = (frame.sbr && frame.ps) ? "SBR+PS" :
+ input_thread_t *p_input = (input_thread_t *)p_dec->p_parent;
+ char *psz_cat;
+ const char *psz_ext = (frame.sbr && frame.ps) ? "SBR+PS" :
frame.sbr ? "SBR" : "PS";
- msg_Dbg( p_dec, "AAC %s (channels: %u, samplerate: %lu)",
- psz_ext, frame.channels, frame.samplerate );
-
- asprintf( &psz_cat, _("Stream %d"), p_dec->fmt_in.i_id );
- input_Control( p_input, INPUT_ADD_INFO, psz_cat,
- _("AAC extension"), "%s", psz_ext );
- input_Control( p_input, INPUT_ADD_INFO, psz_cat,
- _("Channels"), "%d", frame.channels );
- input_Control( p_input, INPUT_ADD_INFO, psz_cat,
- _("Sample rate"), _("%d Hz"), frame.samplerate );
- free( psz_cat );
- p_sys->b_sbr = frame.sbr; p_sys->b_ps = frame.ps;
+ msg_Dbg( p_dec, "AAC %s (channels: %u, samplerate: %lu)",
+ psz_ext, frame.channels, frame.samplerate );
+
+ if( asprintf( &psz_cat, _("Stream %d"), p_dec->fmt_in.i_id ) != -1 )
+ {
+ input_Control( p_input, INPUT_ADD_INFO, psz_cat,
+ _("AAC extension"), "%s", psz_ext );
+ input_Control( p_input, INPUT_ADD_INFO, psz_cat,
+ _("Channels"), "%d", frame.channels );
+ input_Control( p_input, INPUT_ADD_INFO, psz_cat,
+ _("Sample rate"), _("%d Hz"), frame.samplerate );
+ free( psz_cat );
+ }
+ p_sys->b_sbr = frame.sbr; p_sys->b_ps = frame.ps;
}
/* Convert frame.channel_position to our own channel values */
More information about the vlc-devel
mailing list