[vlc-devel] commit: Fix crash when (access_t*)->pf_control is NULL ( Rafaël Carré )
rem at videolan.org
Thu Mar 13 14:37:29 CET 2008
Le Thursday 13 March 2008 14:23:19 Rafaël Carré, vous avez écrit :
> On Thu, 2008-03-13 at 01:21 +0200, Rémi Denis-Courmont wrote:
> > Le Thursday 13 March 2008 01:17:09 git version control, vous avez écrit :
> > > vlc | branch: master | Rafaël Carré <funman at videolan.org> | Thu Mar 13
> > > 00:05:27 2008 +0100| [cd2de36f617b57813c44fd94babd7fa952bccf8d]
> > >
> > > Fix crash when (access_t*)->pf_control is NULL
> > I think this is illegal. Revert this and fix the DBus module.
> I'll have a deeper look.
> DBus doesn't use "legal" access API, but vlc_object_find() and might
> find an access module which is not ready yet to be controlled
Checking for pf_control won't fix that. Plugins simply do not expect their
callback to be invoked before they return successfully from Open. In other
words, you may end up calling the pf_control of an earlier access whose
probing failed, or you may call pf_control while the internal state (p_sys)
of the access is not fully initialized.
Please revert this, it's plain simply broken.
More information about the vlc-devel