[vlc-devel] commit: Link ncurses plugin to libtinfo if available. (Pavlov Konstantin )

[Rafaël Carré]

On Sun, 2008-03-16 at 23:32 +0100, git version control wrote:
> vlc | branch: master | Pavlov Konstantin <thresh at altlinux.ru> | Mon Mar 17 01:10:02 2008 +0300| [e5979c33103d684a7422c9f291edb9baf295d601]
> 
> Link ncurses plugin to libtinfo if available.
> Should fix builds on linuxes using that library: ALT, PLD, Fedora.
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e5979c33103d684a7422c9f291edb9baf295d601
> ---
> 
>  configure.ac |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 7cfd5cb..4e3239a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -5390,11 +5390,13 @@ AC_ARG_ENABLE(ncurses,
>          VLC_ADD_LIBS([ncurses],[-lncursesw])
>          ALIASES="${ALIASES} nvlc"
>          AC_DEFINE([HAVE_NCURSESW], 1, [Define to 1 if you have libncursesw.])
> +        AC_CHECK_LIB(tinfo, tgetent, VLC_ADD_LIBS([ncurses],[-ltinfo]))
>          ],
>          [AC_CHECK_LIB( ncurses, mvprintw,
>            [VLC_ADD_PLUGINS([ncurses])
>            ALIASES="${ALIASES} nvlc"
> -          VLC_ADD_LIBS([ncurses],[-lncurses])],
> +          VLC_ADD_LIBS([ncurses],[-lncurses])
> +          AC_CHECK_LIB(tinfo, tgetent, VLC_ADD_LIBS([ncurses],[-ltinfo]))],
>            [AS_IF([test "x${enable_ncurses}" != "x"], [
>              AC_MSG_ERROR([libncurses not found])])]
>          )]

Why are you doing the check 2 times ?
You should put this one in first, just before the
AC_CHECK_HEADER(ncurses.h,...)

-- 
Rafaël Carré <funman at videolan.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080317/742b79f0/attachment.sig>