[vlc-devel] commit: Fix #1487 ( Rafaël Carré )

git version control git at videolan.org
Mon Mar 17 21:33:25 CET 2008


vlc | branch: master | Rafaël Carré <funman at videolan.org> | Mon Mar 17 21:32:09 2008 +0100| [eb85f7afc2685c9973973a8d6c1a4530c6b77972]

Fix #1487

Don't use an object after releasing it

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=eb85f7afc2685c9973973a8d6c1a4530c6b77972
---

 modules/gui/qt4/input_manager.cpp |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/modules/gui/qt4/input_manager.cpp b/modules/gui/qt4/input_manager.cpp
index cee7193..4b81c07 100644
--- a/modules/gui/qt4/input_manager.cpp
+++ b/modules/gui/qt4/input_manager.cpp
@@ -108,18 +108,17 @@ void InputManager::delInput()
     if( p_input )
     {
         delCallbacks();
-        vlc_object_release( p_input );
         i_old_playing_status = END_S;
-
         i_input_id = 0;
         old_name   = "";
         artUrl     = "";
-        p_input    = NULL;
         emit positionUpdated( 0.0, 0 ,0 );
         emit statusChanged( END_S );
         emit nameChanged( "" );
         emit artChanged( "" );
         emit rateChanged( INPUT_RATE_DEFAULT );
+        vlc_object_release( p_input );
+        p_input = NULL;
     }
 }
 




More information about the vlc-devel mailing list