[vlc-devel] commit: control/media_instance.c: Fix libvlc_media_instance_new_from_input_thread() now that input refcounting is fixed. (Pierre d'Herbemont )

git version control git at videolan.org
Wed Mar 19 02:06:20 CET 2008


vlc | branch: master | Pierre d'Herbemont <pdherbemont at free.fr> | Wed Mar 19 02:05:06 2008 +0100| [af3a9f1bda52929ead2943edda814bdd8a6d2538]

control/media_instance.c: Fix libvlc_media_instance_new_from_input_thread() now that input refcounting is fixed.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=af3a9f1bda52929ead2943edda814bdd8a6d2538
---

 src/control/media_instance.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/src/control/media_instance.c b/src/control/media_instance.c
index c11d733..3150c6c 100644
--- a/src/control/media_instance.c
+++ b/src/control/media_instance.c
@@ -103,9 +103,6 @@ static void release_input_thread( libvlc_media_instance_t *p_mi )
     }
     else
     {
-        /* XXX: hack the playlist doesn't retain the input thread,
-         * so we did it for the playlist (see _new_from_input_thread),
-         * revert that here. This will be deleted with the playlist API */
         vlc_object_release( p_input_thread );
     }
 
@@ -410,10 +407,6 @@ libvlc_media_instance_t * libvlc_media_instance_new_from_input_thread(
     /* will be released in media_instance_release() */
     vlc_object_yield( p_input );
 
-    /* XXX: Hack as the playlist doesn't yield the input thread we retain
-     * the input for the playlist. (see corresponding hack in _release) */
-    vlc_object_yield( p_input );
-
     return p_mi;
 }
 




More information about the vlc-devel mailing list