[vlc-devel] [PATCH] Dbus control module:
funman at videolan.org
Thu Mar 20 15:10:52 CET 2008
On Thu, 2008-03-20 at 01:25 +0100, Mirsal Ennaime wrote:
> Here is yet another D-Bus patch.
> The diff is quite messed up and hard to read, sorry.
Yeah diff(1) sometimes makes bullshit.
> @funman, could you double-check this ?
Looks ok, will perform the 2nd check this week-end ;)
+ /* We're called from the playlist, so that would cause locking
+ /* UpdateCaps( p_intf ); */
Have a look at playlist_ItemGetById() on how to solve that problem.
@@ -924,6 +900,7 @@ static int StateChange( vlc_object_t *p_this, const
StatusChangeSignal( p_sys->p_conn, (void*) p_intf );
The patch is already hard to read and you add useless newlines ? :(
+ if( p_intf->p_sys->b_meta_read )
+ i_caps |= CAPS_CAN_PROVIDE_METADATA;
- var_AddCallback( p_input, "state", StateChange, p_intf );
+ if( i_caps != p_intf->p_sys->i_caps )
+ p_intf->p_sys->i_caps = i_caps;
+ CapsChangeSignal( p_intf->p_sys->p_conn,
When it is used several times, you can improve readability with:
intf_sys_t *p_sys = p_intf->p_sys;
P.S. Why do you sign-off your patches yourself?
Rafaël Carré <funman at videolan.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: This is a digitally signed message part
More information about the vlc-devel