[vlc-devel] [PATCH] Added video-filter RemoteOSD

[techfreak]

Rafaël Carré schrieb:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Le Mon, 24 Mar 2008 20:52:17 +0100,
> techfreak <smile4you at gmx.ch> a écrit :
>
>   
>> Hello Rafaël
>>
>> I made the changes with libgcrypt now and it compiles and links fine.
>>
>> Also I re-checked-out vlc from git and made one single patch with all
>> my changes.
>>     
>
> You should disable your plugin when libgcrypt has not been found, and
> error out if the plugin was explicitely selected.
>
>   
Yes. That's exactly what I tryed to do with the following lines,
is this not correct (VLC_ADD_PLUNINS is inside of the check
AS_IF([test "${have_libgcrypt}" = "yes"])?


dnl
dnl RemoteOSD plugin (VNC client as video filter)
dnl
AC_ARG_ENABLE(remoteosd,
  [  --enable-remoteosd         RemoteOSD plugin (default enabled)])

AS_IF([test "${enable_remoteosd}" != "no"], [
  AS_IF([test "${have_libgcrypt}" = "yes"],[
    VLC_ADD_PLUGINS([remoteosd])
    VLC_ADD_LIBS([remoteosd], ${GCRYPT_LIBS})
    VLC_ADD_CFLAGS([remoteosd], ${GCRYPT_CFLAGS})
  ], [
    AC_MSG_ERROR([libgcrypt support required for RemoteOSD plugin])
  ])
])
 
> + * Copyright (C) 2004-2007 M2X
> I don't think this is correct ;)
>
>   
:-)
>   
>> Unfortuneley the authentication using libgcrypt is rejected by the
>> VNC host and I could not yet find why. But for the main use of my
>> plugin with VDR-ffnetdev streaming authentication is not needed.
>>     
>
> We'll sort at out later, maybe you can use printf("%.2x%.2x...\",
> byte[0], byte[1] ... ); to see where you were wrong in libgcrypt
> utilisation.
>
>   
I will do some tests with re-including the re-invented wheel ;-)
>> I hope you can commit my patch for now and I will search the 
>> authentication problem later. So I may already ask some guys from the 
>> VDR community to test my plugin using a  nightly build of VLC.
>>     
>
> I won't commit before someone experimented with video filters has
> reviewed the patch too.
>
>   
How can I motivate such a person to review it?
>> You can find the patch here: 
>> http://www.digitalhome.ch/tmp_vlc/0001-Added-video-filer-plugin-RemoteOSD.patch.tar.gz
>>     
>
> No need to tar it, gzip is enough for 1 file :)
>   
My wold is windows. It was hard enough to use a linux compression 
instead of  winzip  ;-)
> - -- 
> Rafaël Carré
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.8 (FreeBSD)
>
> iEYEARECAAYFAkfoGdsACgkQYWCeGMCv8Q8CogCfdxnDPNbBJWK8fLD3eGehHi93
> NQMAnRwlezqSWCfDXY4f8g31E+8ahjK/
> =FWFo
> -----END PGP SIGNATURE-----
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>