[vlc-devel] commit: Revert "ActionKeyCB: remove completely." ( Rémi Denis-Courmont )

Jean-Paul Saman jean-paul.saman at planet.nl
Fri Mar 28 12:02:56 CET 2008

Rémi Denis-Courmont wrote:
> Le Thursday 27 March 2008 20:02:33 git version control, vous avez écrit :
>> vlc | branch: master | Rémi Denis-Courmont <rem at videolan.org> | Thu Mar 27
>> 20:03:05 2008 +0200| [f016819850d9d4896a3944bd0e94b73f648ec85b]
>> Revert "ActionKeyCB: remove completely."
>> This reverts commit a859dede77cff629f2f98b84ded198f492bc5222.
> Caught by some doubts, but it does actually seem to be dead code afterall.
> (This implies the key accounting stuff never actually worked, then I wonder 
> why it was backported from 0.8.1-jpsaman-thedj branch in the first place)

It worked in 0.8.x and when I backported it. Maybe it got broken in the 
meantime. Since I don't work on that project anymore, it hasn't been 
high up on my priority list.

The idea was that when eg: over infrared someone pressed the same key 
multiple times that you wanted it to accelerate for some keys. Think of 
forward/backward if you are playing a DVD.

This piece of code is used inside a customer appliance. I don't think 
they are upgrading to latest unstable shortly, but it would have been 
nice if you contacted me about what to do with it before you ripped it out.

Jean-Paul Saman.

More information about the vlc-devel mailing list