[vlc-devel] commit: input: No need to call detach() prior to release() in those cases. (Pierre d'Herbemont )

git version control git at videolan.org
Fri Mar 28 22:58:46 CET 2008


vlc | branch: master | Pierre d'Herbemont <pdherbemont at videolan.org> | Fri Mar 28 22:56:11 2008 +0100| [40f255a1d1576d0af67ddad2a5fe4b573840f341]

input: No need to call detach() prior to release() in those cases.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=40f255a1d1576d0af67ddad2a5fe4b573840f341
---

 src/input/input.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/src/input/input.c b/src/input/input.c
index 8442c93..dbe4a66 100644
--- a/src/input/input.c
+++ b/src/input/input.c
@@ -399,7 +399,6 @@ int __input_Read( vlc_object_t *p_parent, input_item_t *p_item,
         {
             input_ChangeState( p_input, ERROR_S );
             msg_Err( p_input, "cannot create input thread" );
-            vlc_object_detach( p_input );
             vlc_object_release( p_input );
             return VLC_EGENERIC;
         }
@@ -576,7 +575,6 @@ static int RunAndDestroy( input_thread_t *p_input )
 
 exit:
     /* Release memory */
-    vlc_object_detach( p_input );
     vlc_object_release( p_input );
     return 0;
 }




More information about the vlc-devel mailing list