[vlc-devel] commit: stream: Do not yield and then release. It is unuseful here. ( Pierre d'Herbemont )

[git version control]

vlc | branch: master | Pierre d'Herbemont <pdherbemont at videolan.org> | Sat Mar 29 01:02:46 2008 +0100| [9d2636c560417a5fdfc0081983efdd996428cd9c]

stream: Do not yield and then release. It is unuseful here.

Because there is no proper convention, there is no reason why the object couldn't be detached. We would need to vlc_object_find the input to be sure there is no problem. Let's assume for now that the input creates the access and is responsible for it.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9d2636c560417a5fdfc0081983efdd996428cd9c
---

 src/input/stream.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/src/input/stream.c b/src/input/stream.c
index 16ec887..35b6454 100644
--- a/src/input/stream.c
+++ b/src/input/stream.c
@@ -1687,7 +1687,6 @@ static int AReadStream( stream_t *s, void *p_read, int i_read )
         i_read = p_access->pf_read( p_access, p_read, i_read );
         if( p_input )
         {
-            vlc_object_yield( p_input );
             vlc_mutex_lock( &p_input->p->counters.counters_lock );
             stats_UpdateInteger( s, p_input->p->counters.p_read_bytes, i_read,
                              &i_total );
@@ -1695,7 +1694,6 @@ static int AReadStream( stream_t *s, void *p_read, int i_read )
                            (float)i_total, NULL );
             stats_UpdateInteger( s, p_input->p->counters.p_read_packets, 1, NULL );
             vlc_mutex_unlock( &p_input->p->counters.counters_lock );
-            vlc_object_release( p_input );
         }
         return i_read;
     }