[vlc-devel] [PATCH] libvlc: add functions libvlc_get_version() and others
pdherbemont at free.fr
Sat Mar 29 20:49:09 CET 2008
On Mar 29, 2008, at 8:38 PM, Tanguy Krotoff wrote:
> I used git-send-email and it lacks some comments :p
> so this is a small patch to replace old VLC_*() functions to get vlc
> version/compiler/changeset infos
Patch description was perfectly fine IMHO. Else feel free to put more
comment in commit log.
> Also, I'm trying to modify libvlc_media_instance_stop() from
> media_instance.c so that it sends the event
Well, we should get that from an input callback. So core needs to be
fixed for that one.
> I guess it is not good to use input_Control( p_input_thread,
> INPUT_SET_STATE, END_S ); since the input thread is being destroyed.
> So I tried:
> libvlc_event_t event;
> event.type = libvlc_MediaInstanceReachedEnd;
> libvlc_event_send( p_mi->p_event_manager, &event );
> But it crashes inside media_list:
> #3 0xb68a4dbf in vlc_pthread_fatal (action=0xb68f3355 "locking
> mutex", error=35,
> file=0xb68f4410 "control/media_list.c", line=174) at misc/
> #4 0xb68ed385 in libvlc_media_list_release (p_mlist=0x84040e8) at
> #5 0xb68ee5a9 in libvlc_media_list_player_next (p_mlp=0x8436c40,
> p_e=0x0) at control/media_list_player.c:86
> #6 0xb68ee6f5 in media_instance_reached_end (p_event=0xbfc9510c,
> at control/media_list_player.c:116
> #7 0xb68e7ec0 in libvlc_event_send (p_em=0x844c388,
> p_event=0xbfc9510c) at control/event.c:237
> And here I'm a bit lost...
media_list_player is a bit untested. You may want to test only with
media_instance for now.
> I guess the right place for this kind of question is the IRC channel
More information about the vlc-devel