[vlc-devel] [PATCH] libvlc: add functions libvlc_get_version() and others

[Pierre d'Herbemont]

On Mar 29, 2008, at 9:00 PM, Tanguy Krotoff wrote:

> On Sat, Mar 29, 2008 at 8:49 PM, Pierre d'Herbemont <pdherbemont at free.fr 
> > wrote:
>> Could you resend without the Makefile.am edition?
>
> You need the Makefile.am edition.
> this line:
> nodist_libvlc_control_la_SOURCES = misc/revision.c
>
> otherwise you get an unresolved symbol at runtime on:
> psz_vlc_changeset
> which is defined in misc/revision.c

Then the patch is not correct IMO, we don't want to duplicate that  
from libvlc.so. You may want to wrap around the VLC_* function that  
are not deprecated in libvlc. (I would be for renaming those to vlc_,  
but as they were exported you'll need to keep the old VLC_* around too).

Pierre.