[vlc-devel] commit: libvlc: In order not to be confused by a vlm created elsewhere, use a libvlc instance variable to old the vlm libvlc created if --vlm-conf was specified . (Pierre d'Herbemont )

Rémi Denis-Courmont rdenis at simphalempin.com
Mon Mar 31 15:50:57 CEST 2008


Le Monday 31 March 2008 02:12:32 git version control, vous avez écrit :
> vlc | branch: master | Pierre d'Herbemont <pdherbemont at videolan.org> | Mon
> Mar 31 01:02:49 2008 +0200| [4c905528fb38bf6cc6d7b0902192a52415c47776]
>
> libvlc: In order not to be confused by a vlm created elsewhere, use a
> libvlc instance variable to old the vlm libvlc created if --vlm-conf was
> specified.

Hmm... was the VLM object not supposed to be a singleton anyhow?! as is httpd.

> This also make sure the vlm created when --vlm-conf is specified gets
> really destroyed. Because find_object yields vlm and is never released.

While I agree that it's more efficient to store the LibVLC instance VLM as a 
per-instance pointer, I am not a big fan of this big ugly public 
libvlc_int_t :( oh well.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list