[vlc-devel] commit: i_verbose has been privatized ( Rafaël Carré )

Remi Denis-Courmont rdenis at simphalempin.com
Mon May 5 12:49:27 CEST 2008


> *p_instance, unsigned level, li
>  {
>      if( p_instance )
>      {
> -        p_instance->p_libvlc_int->i_verbose = level;
> +        libvlc_priv_t *p_priv = libvlc_priv( p_instance->p_libvlc_int );
> +        p_priv->i_verbose = level;
>      }
>      else
>          RAISEVOID("Invalid VLC instance!");

This cannot be right. Reading i_verbose is ugly, but OK.
Writing i_verbose after any thread has started is _wrong_.

-- 
Rémi




More information about the vlc-devel mailing list