[vlc-devel] commit: i_verbose has been privatized ( Rafaël Carré )
pdherbemont at free.fr
Mon May 5 15:07:38 CEST 2008
On May 5, 2008, at 2:12 PM, Rafaël Carré wrote:
> 2008/5/5 Remi Denis-Courmont <rdenis at simphalempin.com>:
>>> *p_instance, unsigned level, li
>>> if( p_instance )
>>> - p_instance->p_libvlc_int->i_verbose = level;
>>> + libvlc_priv_t *p_priv = libvlc_priv( p_instance-
>>> >p_libvlc_int );
>>> + p_priv->i_verbose = level;
>>> RAISEVOID("Invalid VLC instance!");
>> This cannot be right. Reading i_verbose is ugly, but OK.
>> Writing i_verbose after any thread has started is _wrong_.
> My opinion is: why do these functions exist in the 1st place ?
> Remove them !
> (Message implicitely destinated to Pierre & Olivier)
I am by no way author of the libvlc_*_log() functions. I also don't
More information about the vlc-devel