[vlc-devel] commit: mosaic : Free string variables after using them ( Rafaël Carré )

git version control git at videolan.org
Tue May 6 13:23:31 CEST 2008


vlc | branch: 0.8.6-bugfix | Rafaël Carré <funman at videolan.org> | Tue May  6 11:22:47 2008 +0200| [f2e9aa6fdb70badeb15424d60926a3274dc97bd2]

mosaic : Free string variables after using them

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f2e9aa6fdb70badeb15424d60926a3274dc97bd2
---

 modules/video_filter/mosaic.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/modules/video_filter/mosaic.c b/modules/video_filter/mosaic.c
index 257797a..ef4a78d 100644
--- a/modules/video_filter/mosaic.c
+++ b/modules/video_filter/mosaic.c
@@ -2,7 +2,7 @@
  * mosaic.c : Mosaic video plugin for vlc
  *****************************************************************************
  * Copyright (C) 2004-2005 the VideoLAN team
- * $Id$
+ * $Id: 257797ae49700529a0f45e44f8c68ed04800f396 $
  *
  * Authors: Antoine Cellerier <dionoea at via.ecp.fr>
  *          Christophe Massiot <massiot at via.ecp.fr>
@@ -225,7 +225,7 @@ static int CreateFilter( vlc_object_t *p_this )
     filter_t *p_filter = (filter_t *)p_this;
     filter_sys_t *p_sys;
     libvlc_t *p_libvlc = p_filter->p_libvlc;
-    char *psz_order;
+    char *psz_order, *_psz_order;
     int i_index;
     vlc_value_t val;
 
@@ -294,7 +294,7 @@ static int CreateFilter( vlc_object_t *p_this )
 
     p_sys->i_order_length = 0;
     p_sys->ppsz_order = NULL;
-    psz_order = var_CreateGetString( p_filter, "mosaic-order" );
+    psz_order = _psz_order = var_CreateGetString( p_filter, "mosaic-order" );
 
     if( psz_order[0] != 0 )
     {
@@ -313,6 +313,8 @@ static int CreateFilter( vlc_object_t *p_this )
         p_sys->i_order_length = i_index;
     }
 
+    free( _psz_order );
+
     /* Bluescreen specific stuff */
     GET_VAR( bsu, 0x00, 0xff );
     GET_VAR( bsv, 0x00, 0xff );




More information about the vlc-devel mailing list