[vlc-devel] commit: Don't redefine MODULE_STRING ( Rémi Denis-Courmont )

git version control git at videolan.org
Thu May 8 18:43:24 CEST 2008


vlc | branch: master | Rémi Denis-Courmont <rem at videolan.org> | Thu May  8 19:26:30 2008 +0300| [6433e0e9d04c6218ba2ea3e213b2dfe10286a217]

Don't redefine MODULE_STRING

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6433e0e9d04c6218ba2ea3e213b2dfe10286a217
---

 include/vlc_plugin.h |   12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/include/vlc_plugin.h b/include/vlc_plugin.h
index 635f2b4..6b6ccae 100644
--- a/include/vlc_plugin.h
+++ b/include/vlc_plugin.h
@@ -43,19 +43,13 @@
 
 /* Explanation:
  *
- * if user has #defined MODULE_NAME foo, then we will need:
- * #define MODULE_STRING "foo"
- *
- * and, if HAVE_DYNAMIC_PLUGINS is NOT set, we will also need:
+ * if HAVE_DYNAMIC_PLUGINS is NOT set, we will need:
  * #define MODULE_FUNC( zog ) module_foo_zog
  *
  * this can't easily be done with the C preprocessor, thus a few ugly hacks.
  */
 
-/* I can't believe I need to do this to change « foo » to « "foo" » */
-#define STRINGIFY( z )   UGLY_KLUDGE( z )
-#define UGLY_KLUDGE( z ) #z
-/* And I need to do _this_ to change « foo bar » to « module_foo_bar » ! */
+/* I need to do _this_ to change « foo bar » to « module_foo_bar » ! */
 #define CONCATENATE( y, z ) CRUDE_HACK( y, z )
 #define CRUDE_HACK( y, z )  y##__##z
 
@@ -86,8 +80,6 @@
 #   define EXTERN_SYMBOL
 #endif
 
-#define MODULE_STRING STRINGIFY( MODULE_NAME )
-
 /*
  * InitModule: this function is called once and only once, when the module
  * is looked at for the first time. We get the useful data from it, for




More information about the vlc-devel mailing list