[vlc-devel] commit: Don't use multiple lines macros in if conditions ( Rafaël Carré )

git version control git at videolan.org
Thu May 8 22:29:20 CEST 2008


vlc | branch: master | Rafaël Carré <funman at videolan.org> | Thu May  8 22:26:24 2008 +0200| [923e80b5c2a7372b98cbee47c01a078cfab1904c]

Don't use multiple lines macros in if conditions

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=923e80b5c2a7372b98cbee47c01a078cfab1904c
---

 modules/gui/ncurses.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/modules/gui/ncurses.c b/modules/gui/ncurses.c
index 28cfbd5..f14b5a4 100644
--- a/modules/gui/ncurses.c
+++ b/modules/gui/ncurses.c
@@ -568,12 +568,16 @@ static int HandleKey( intf_thread_t *p_intf, int i_key )
     vlc_value_t val;
     
     #define ReturnTrue \
+    do { \
     vlc_object_release( p_playlist ); \
-    return 1
+    return 1; \
+    } while(0)
     
     #define ReturnFalse \
+    do { \
     vlc_object_release( p_playlist ); \
-    return 0
+    return 0; \
+    } while(0)
 
     playlist_t *p_playlist = pl_Yield( p_intf );
 




More information about the vlc-devel mailing list