[vlc-devel] commit: Don't assert that something that can fail won't fail... ( Rémi Denis-Courmont )

git version control git at videolan.org
Sat May 10 22:21:02 CEST 2008


vlc | branch: master | Rémi Denis-Courmont <rem at videolan.org> | Sat May 10 22:49:25 2008 +0300| [b855dc8d8261eeb21f6eb7db770768701dea98d9]

Don't assert that something that can fail won't fail...

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b855dc8d8261eeb21f6eb7db770768701dea98d9
---

 src/misc/messages.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/misc/messages.c b/src/misc/messages.c
index a5a5be9..100d61e 100644
--- a/src/misc/messages.c
+++ b/src/misc/messages.c
@@ -618,7 +618,9 @@ void msg_StackSet( int i_code, const char *psz_message, ... )
 {
     va_list ap;
     msg_context_t *p_ctx = GetContext();
-    assert( p_ctx );
+
+    if( p_ctx == NULL )
+        return;
 
     va_start( ap, psz_message );
     free( p_ctx->psz_message );
@@ -635,7 +637,9 @@ void msg_StackAdd( const char *psz_message, ... )
     char *psz_tmp;
     va_list ap;
     msg_context_t *p_ctx = GetContext();
-    assert( p_ctx );
+
+    if( p_ctx == NULL )
+        return;
 
     va_start( ap, psz_message );
     if( vasprintf( &psz_tmp, psz_message, ap ) == -1 )




More information about the vlc-devel mailing list