[vlc-devel] commit: Fix cyclic dependancy between input and "sout stream" description ( Rafaël Carré )

[Rafaël Carré]

Le Tue, 13 May 2008 14:58:49 +0200,
Remi Denis-Courmont <rdenis at simphalempin.com> a écrit :

> 
> On Tue, 13 May 2008 12:14:49 +0200 (CEST), git at videolan.org (git
> version control) wrote:
> > vlc | branch: master | Rafaël Carré <funman at videolan.org> | Tue May
> > 13 12:15:42 2008 +0200| [8a0dc31dcad18b36c9545910c0e09b22a4c6c020]
> > 
> > Fix cyclic dependancy between input and "sout stream" description
> 
> Wrong. Broken. (And ugly.)
> 
> A sout plugin CAN be "unparented" and change input. That's the whole
> point of --sout-keep.

No, cannot.

http://git.videolan.org/?p=vlc.git;a=blob;f=src/input/vlm.c;h=6c00d7f9d37c7df83f8d0554899b0cf2b21517d1;hb=HEAD#l507

This is the only place where description is used, notice the
--no-sout-keep option just following.

> Hence a sout plugin must yield the input (or any other foreign
> object) for as long as it needs it. Please revert.
> 


-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080514/96516c4b/attachment.sig>