[vlc-devel] commit: Revert "vlc: Make sure we call libvlc_release() when we are requested to die." (Pierre d'Herbemont )

git version control git at videolan.org
Thu May 15 22:54:43 CEST 2008


vlc | branch: master | Pierre d'Herbemont <pdherbemont at videolan.org> | Thu May 15 22:55:01 2008 +0200| [82abb3013a56507f3431eab49480d53376e5965f]

Revert "vlc: Make sure we call libvlc_release() when we are requested to die."

This reverts commit 68bcb6a4322b55b70c231a597d7b45a5406fd7f8.

As pointed by courmisch, this is crashy.

Conflicts:

	src/vlc.c

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=82abb3013a56507f3431eab49480d53376e5965f
---

 src/vlc.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/vlc.c b/src/vlc.c
index 922ef17..deaba4b 100644
--- a/src/vlc.c
+++ b/src/vlc.c
@@ -56,9 +56,6 @@ extern void __wgetmainargs(int *argc, wchar_t ***wargv, wchar_t ***wenviron,
 static void *SigHandler (void *set);
 #endif
 
-/* running vlc instance */
-static libvlc_instance_t * vlc = NULL;
-
 /*****************************************************************************
  * main: parse command line, start interface and spawn threads.
  *****************************************************************************/
@@ -187,7 +184,7 @@ int main( int i_argc, const char *ppsz_argv[] )
     libvlc_exception_init (&ex);
 
     /* Initialize libvlc */
-    vlc = libvlc_new (i_argc, ppsz_argv, &ex);
+    libvlc_instance_t *vlc = libvlc_new (i_argc, ppsz_argv, &ex);
     if (vlc != NULL)
     {
         libvlc_run_interface (vlc, NULL, &ex);
@@ -255,7 +252,7 @@ static void *SigHandler (void *data)
 
             fprintf (stderr, "signal %d received, terminating vlc - do it "
                             "again quickly in case it gets stuck\n", i_signal);
-            if (vlc) libvlc_release (vlc);
+            //VLC_Die( 0 );
         }
         else /* time (NULL) <= abort_time */
         {




More information about the vlc-devel mailing list