[vlc-devel] commit: vlc: Make sure we call libvlc_release() when we are requested to die. (Pierre d'Herbemont )

[Pierre d'Herbemont]

On May 15, 2008, at 10:34 PM, Rémi Denis-Courmont wrote:

> Le Thursday 15 May 2008 23:13:25 git version control, vous avez  
> écrit :
>> vlc | branch: master | Pierre d'Herbemont  
>> <pdherbemont at videolan.org> | Thu
>> May 15 22:13:41 2008 +0200|  
>> [68bcb6a4322b55b70c231a597d7b45a5406fd7f8]
>>
>> vlc: Make sure we call libvlc_release() when we are requested to die.
>
> Hey! I would have done that if it DID work. But... libvlc_release()  
> could be
> called multiple times from the signal handing thread -> boom. And it  
> could be
> called both in the signal handler thread and in the main thread ->  
> boom.

Reverted.

>> Note: I don't think we did yet match the old behaviour, if we hit  
>> ctrl-c
>> while in libvlc_new(), vlc isn't killed properly.
>
> IMHO, we should not handle Ctrl+C at all. Most GUI program don't.

I don't like that much programs that don't respond to Ctrl-C. But  
that's a taste question. Feel free to do whatever you prefer, here.

Pierre.