[vlc-devel] commit: Detach the children at object destruction ( Rafaël Carré )

[Pierre d'Herbemont]

On May 16, 2008, at 2:19 PM, Rafaël Carré wrote:

> 2008/5/16 Remi Denis-Courmont <rdenis at simphalempin.com>:
>>
>> On Fri, 16 May 2008 14:02:39 +0200 (CEST), git at videolan.org (git  
>> version
>> control) wrote:
>>> vlc | branch: master | Rafaël Carré <funman at videolan.org> | Fri  
>>> May 16
>>> 14:03:48 2008 +0200| [e5b3d194ffa17dcbf57e69ebf83c3730e8938932]
>>>
>>> Detach the children at object destruction
>>
>> This is as wrong as the previous commit.
>
> How ?
> Maybe setting i_children to 0 is the correct way, but then why is
> there a check in vlc_object_destroy() ?

The problem we are facing comes from the fact that if p_parent is set  
to NULL, then the child object can't be vlc_object_detach()-ed. So, it  
basically remains as a children.

Something is wrong somewhere.

A quick fix would be to remove the check, and hope that we'll just get  
the leaked object when libvlc is destroyed. But I think that's not  
clean enough.

Pierre.