[vlc-devel] commit: Detach the children at object destruction ( Rafaël Carré )

[Pierre d'Herbemont]

On May 16, 2008, at 4:39 PM, Rémi Denis-Courmont wrote:

> Le Friday 16 May 2008 15:48:10 Pierre d'Herbemont, vous avez écrit :
>>> I have a patch for that. Please review and apply.<0001-objects-
>>> Protect-from-FIND_PARENT-directly-in-the-FI.patch>
>>
>> (without typo this time)
>
> This does not work. For a start, outside of the refspin, there is no  
> warranty
> that i_refcount is in a safe, so if another thread is yielding/ 
> releasing the
> parent at the same time, you will get undefined behaviour.

Well, added the forgotten spinlock locking.

Pierre.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-objects-Protect-from-FIND_PARENT-directly-in-the-FI.patch
Type: application/octet-stream
Size: 4017 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080516/2266eebf/attachment.obj>
-------------- next part --------------