[vlc-devel] commit: Remove useless volatile keyword ( Rémi Denis-Courmont )

git version control git at videolan.org
Mon May 19 17:22:29 CEST 2008


vlc | branch: master | Rémi Denis-Courmont <rem at videolan.org> | Mon May 19 18:23:56 2008 +0300| [f2312da8a85f4646ac97ce46bc98a08dd3d2de4b]

Remove useless volatile keyword

In this case, volatile was both incorrect (volatile does nothing about
thread synchronization) and not required (there is an explicit lock).

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f2312da8a85f4646ac97ce46bc98a08dd3d2de4b
---

 src/libvlc-common.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/libvlc-common.c b/src/libvlc-common.c
index 76c241d..2efc6c8 100644
--- a/src/libvlc-common.c
+++ b/src/libvlc-common.c
@@ -99,7 +99,7 @@
  * The evil global variables. We handle them with care, don't worry.
  *****************************************************************************/
 static libvlc_int_t *    p_static_vlc = NULL;
-static volatile unsigned int i_instances = 0;
+static unsigned          i_instances = 0;
 
 static bool b_daemon = false;
 




More information about the vlc-devel mailing list