[vlc-devel] [PATCH] RealVideo Support
jb at videolan.org
Fri May 23 06:34:46 CEST 2008
On Fri, May 23, 2008 at 04:23:49PM +1200, 王波 wrote :
> > I just have a few random questions, and many of them are cosmetic. :D
> my pleasure. :)
No, mine. I am not used to review patches.
> > - Can you split the rstp part and the realvideo part or are they linked
> > too much ? Same for the realvideo decoder and the demuxer
> > modifications...
> yes, i can split the patch to 3 part.
Seriously, the more you split, the best it is for us.
> > - Why do you remove the AC_CHECK_FUNCS on uselocale ?
> configure.ac ?
> since i do the work in 0.8.6, maybe it is problem when i switch to git
Probably. please focus on 0.9.0-git :D
> > - Why is RtspReadAndSkip( ) returning int if you never check the return
> > value and always return 0 ? Why not void ?
> design but not impliment, maybe it should return some bytes which skipped.
> but in fact the bytes is meaningless.
> > can be used as free( psz ) in vlc. So, the modifications on that are
> > useless... This was discussed on this mailing list before, IIRC.
> o, i don't know and not sure. maybe i can remove the useless if.
Well, all the implementation we use to compile vlc have a free() that
make the check, so no reason to add it too.
> > - Why removing intf_UserFatal ? (this might be a good idea, btw)
> don't know more about intf_UserFatal. ...
ok. I am not against removing it.
> > - Why removing case ACCESS_GET_CONTENT_TYPE: ?
> maybe it be add in new git version.
> i will add it
Well, yes, pleasE.
> (uint8_t*) maybe is added in git version... my original code a little old.
Well, same as above.
> > - On realvideo.c there is a realaudio.c header. Copyright dates are
> > wrong.
> > - You have many commented lines that you add, why ?
> ok, because the patch not perfect , so i record some comments/codes for
> improve. maybe i need clean it.
yes, keep the comments, but try to clean them a bit.
> yes, the realvideo's patch is coming from it, and i do improve about rtsp,
> demux, etc.
yes, I have seen that.
> ok, i will review the code and submit again, hehe .
> i must agree, i an not too professional as a programmer. :(
Thanks for your work and keep the good work.
More information about the vlc-devel